Test Coverage Improvement: isRateLimitToolResult and extractRateLimitErrorText

Function Analyzed

• Package: internal/server
• Functions: isRateLimitToolResult, extractRateLimitErrorText
• Previous Coverage: Exercised only indirectly via circuit_breaker_test.go integration tests
• New Coverage: Direct unit tests covering all branches
• Complexity: Medium — multiple type-switch branches, conditional error flag check, reset-time parsing delegation

Why These Functions?

isRateLimitToolResult contains several code paths that determine whether a raw tool result represents a GitHub rate-limit error and parses an optional reset timestamp. extractRateLimitErrorText extracts the human-readable error message for agents. Both were only reachable through higher-level circuit-breaker integration tests, leaving the individual branches (non-map input, missing isError, various rate-limit phrases, reset-time parsing) without dedicated coverage.

Tests Added

TestExtractRateLimitErrorText

• ✅ Non-map result returns default message
• ✅ Nil result returns default message
• ✅ Integer result returns default message
• ✅ Map without content key returns default message
• ✅ Map with empty content slice returns default message
• ✅ Map with text content returns that text
• ✅ Map with non-text content type returns default message
• ✅ Map with multiple content items returns concatenated text

TestIsRateLimitToolResult

• ✅ Non-map result returns (false, zero time)
• ✅ Nil result returns (false, zero time)
• ✅ isError: false with rate-limit text returns false
• ✅ Missing isError field returns false
• ✅ isError: true with non-rate-limit text returns false
• ✅ isError: true with "rate limit exceeded" text returns true
• ✅ isError: true with "secondary rate limit" text returns true
• ✅ isError: true with "too many requests" text returns true
• ✅ isError: true with "rate limit 403" text returns true
• ✅ isError: true with reset-time in text returns true and non-zero time.Time
• ✅ isError: true with empty content returns false
• ✅ isError: true with no content key returns false

Generated by Test Coverage Improver
Next run will target the next most complex under-tested function

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "go.opentelemetry.io"
    - "go.yaml.in"
    - "golang.org"
    - "google.golang.org"
    - "gopkg.in"
    - "proxy.golang.org"
    - "releaseassets.githubusercontent.com"

Generated by Test Coverage Improver · 745.6 AIC · ⊞ 6.9K · ◷